[Ardour-Users] Ardour contributions ( was: Level needed ... )

[Chris Caudle]

On Fri, March 2, 2018 8:11 am, Ben Loftis wrote:
> ....more ideas welcome!

Is there any interest in minor changes that (probably) don't have any
effect on functionality?
I see pages of warnings like this when building:
../gtk2_ardour/ardour_ui_dialogs.cc:439:33: warning: missed loop
optimization, the loop counter may overflow [-Wunsafe-loop-optimizations]
  for (i = candidates.begin(); i != candidates.end(); ++i) {
                               ~~^~~~~~~~~~~~~~~~~~~


Not a big deal, but at one point I was habituated to make sure code
compiled without warnings both to make sure any real logic errors did not
slip through, and also to make sure the compiler was able to optimize
fully.  In this case the warning is about a missed optimization, I assume
that the counter isn't really going to overflow, or if it does wrap around
and count twice it won't hurt anything, but I haven't looked at that
section in enough detail to make sure there are no corner cases.

-- 
Chris Caudle