[Ardour-Dev] Compiler warnings

[Paul Davis]

On Sun, Sep 13, 2009 at 10:35 AM, John Emmas <johne53 at tiscali.co.uk> wrote:
> Yesterday I updated to Ardour 2.8.2 (svn5656).  When I compiled it I noticed
> the following warnings.  They might have been there for ages but I've never
> noticed them before.  If anyone can confirm these are bugs I'll enter them
> into mantis:-
>
> Warning 1: (gtk2_ardour/editor_route_list.cc - line 157)
> If the 'if' statement returns track_views.end(), 'next_tv' will be
> uninitialized.

fixed. thanks.

> Warning 2: (gtk2-ardour/ardour_ui.cc - line 3104)
> use of 'tempnam()' is dangerous (don't know why - but that's what the
> warning said).  It recommends 'mkstemp()' instead.

we'll fix this at some point. its been done in 3.0 already.

> Warning 3: (gtk2_ardour/plugin_ui.cc - line 303)
> PluginUIWindow::on_key_press_event() is supposed to return a bool, but
> doesn't return anything.

already fixed in my local tree - i just hadn't pushed it yet. fixed
now (rev 5660)