<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 12, 2015 at 7:46 AM, John Emmas <span dir="ltr"><<a href="mailto:johne53@tiscali.co.uk" target="_blank">johne53@tiscali.co.uk</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"><div><div class="h5">
<div>On 09/05/2015 07:25, Paul Davis wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div>(this is really just for developers with write/push access
to the Ardour git repository)<br>
</div>
<div><br>
Attempts to push code that doesn't comply with the Ardour
style guide to <a href="http://git.ardour.org" target="_blank">git.ardour.org</a> will now
fail.<br>
<br>
</div>
There may be a few teething troubles as we get this started. Let
me know if you run into issues.<br>
</div>
<br>
</blockquote>
<br></div></div>
Hi Paul,<br>
<br>
I've been experimenting with this on Windows to see if I can make it
work with TortoiseGit (which I can't). Python gives me a runtime
error saying "Py_Initialize: can't initialize sys standard streams -
LookupError: unknown encoding: cp0".<br></div></blockquote><div><br></div><div>which version of python do you have installed?<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div text="#000000" bgcolor="#FFFFFF">
<br>
I do have a little more success if I try committing from a command
line but it's not hugely better. Maybe I happened to pick a bad
file to test with - but I get dozens of errors from
'libs/backends/jack/jack_utils.cc' - just in the existing code. For
example, all these lines fail, starting at line 139:-<br>
<br>
samplerates.push_back (_("8000Hz"));<br>
samplerates.push_back (_("22050Hz"));<br>
samplerates.push_back (_("44100Hz"));<br>
samplerates.push_back (_("48000Hz"));<br>
samplerates.push_back (_("88200Hz"));<br>
samplerates.push_back (_("96000Hz"));<br>
samplerates.push_back (_("192000Hz"));<br>
<br>
All the above give me "missing space before open parenthesis". </div></blockquote><div><br></div><div>good catch. the tests came from erik de castro lopo, the author of libsndfile. he probably has never used gettext() (libsndfile certainly doesn't) so the _("...") form is not covered. I'll fix that.<br></div><div><br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div text="#000000" bgcolor="#FFFFFF">But
perhaps most damningly, any function call at all - e.g.<br>
<br>
whatever ();<br>
<br>
gives me "missing space after close parenthesis". Just flagging
these up to you.<span class="HOEnZb"><font color="#888888"><br></font></span></div></blockquote><div><br></div><div>ah yes, erik likes to write <br><br></div><div> whatever () ;<br><br></div><div>i'll fix that one also. thanks for playing around with this.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div text="#000000" bgcolor="#FFFFFF"><span class="HOEnZb"><font color="#888888">
<br>
John<br>
</font></span></div>
<br>_______________________________________________<br>
ardour-dev mailing list<br>
<a href="mailto:ardour-dev@lists.ardour.org">ardour-dev@lists.ardour.org</a><br>
<a href="http://lists.ardour.org/listinfo.cgi/ardour-dev-ardour.org" target="_blank">http://lists.ardour.org/listinfo.cgi/ardour-dev-ardour.org</a><br>
<br></blockquote></div><br></div></div>