[Ardour-Dev] Feedback on string-convert branch

Paul Davis paul at linuxaudiosystems.com
Fri Jan 6 01:20:06 PST 2017

I've read through Tim's email descrption of string-convert and taken a
quick look at the code.

There's a lot of good work here that I think has many net benefits.

My concern is that the changes are not enough to ensure that locale issues
are fully addressed without using locale (either because of 3rd party code
or local coding changes). If they don't ensure this, then it just comes
down to whether there are any direct costs to switching to the
string-convert approach AND whether it is an improvement to have *two*
systems of ensuring locale-independent serialization, one explicit and one

I am not totally clear on the answers to these two questions.


On Thu, Jan 5, 2017 at 5:16 PM, Robin Gareus <robin at gareus.org> wrote:

> On 01/05/2017 04:55 PM, John Emmas wrote:
> > On 05/01/2017 14:24, Robin Gareus wrote:
> >> Since I don't know the MSVC build-environment and build-dependencies
> >> used there a quick-solution would be an #ifndef COMPILER_MSVC
> >>
> > Yeah, I guess that should help - but does this effectively mean that
> > translations / internationalization etc won't work any more for an MSVC
> > build?
> >
> Depends on the preference setting.  There is a new mode to only set
> LC_MESSAGES and leave the rest of the locale alone (to investigate
> issues with plugins, see the other branch in this email thread)
> It needs to be explicitly enabled in Preferences > Global > Translations
> The default hasn't changed and Ardour still sets LC_ALL. So there should
> be no change WRT to translations compared to prior MSVC builds.
> Since gettext() chooses the translation based on LC_MESSAGES [1], I'm
> curious how this works with MSVC builds if there's no LC_MESSAGES.
> ciao,
> robin
> [1]
> https://www.gnu.org/software/libc/manual/html_node/Using-
> gettextized-software.html
> _______________________________________________
> ardour-dev mailing list
> ardour-dev at lists.ardour.org
> http://lists.ardour.org/listinfo.cgi/ardour-dev-ardour.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ardour.org/pipermail/ardour-dev-ardour.org/attachments/20170106/e3dab792/attachment-0002.htm>

More information about the Ardour-Dev mailing list