[Ardour-Dev] Bad visual feedback for KORG nanoKONTROL 2

[Len Ovens]

On Sat, 26 Aug 2017, David Kastrup wrote:

> So it would seem that the uri-style controls echo their state back into
> the nanoKONTROL2 while the function/action style controls don't.

Menu action commands will never give feedback. In general they tell the 
GUI to do something.

> In a nutshell:
>
> a) advice at the top of the midimap file(s) is bad.  The only change
> that's actually warranted over the default is switching LED control to
> external instead of internal

Feel free to create a better map and submit it as a pr on github. I do not 
know if it is better to leave the current map alone and create a new one, 
or fix the one that is there. I would test it well though. If you have a 
button that is a CC, toggle will work better. If you have a button that is 
a note then button is fine. A note event is expected to be a note on 
followed by note off and toggling is done inside Ardour. A CC is expected 
to send the desired state to Ardour and handle it's own toggling. This is 
really what the MIDI standard is too. There is a parameter for buttons to 
make them act CC like and only stay true while the button is held, but 
there is no parameter to make a CC work button like.

> b) channel controls S/M/R are not lit initially when a session with set
> controls is loaded

Do you know if they light when banked?

> c) transport controls are never lit
>
> Now for having the computer (and its rotating disk and fan) in a
> different room and just taking the nanoKONTROL2 in the recording room,
> not getting visual feedback for the "PLAY" and "REC" buttons is awkward.
>
> Any chance someone will change this given suitable feedback/info, or at
> least good pointers at what would need changing here?  I can submit a
> patch for a) but am somewhat without a clue for the rest.

There is already a bug filed for c): 
http://tracker.ardour.org/view.php?id=7288

But I am not aware of one for B) at this time. If you are filing one, 
please see if banking has the same problem. If not, it may be as easy as 
resetting the bank at session load. Please note that I have not looked at 
the generic midi control code for some time. So I could be wrong. Working 
on the Ardour codebase in this area is, in my opinion, a good place to 
start. It is not realtime code.

--
Len Ovens
www.ovenwerks.net