[Ardour-Dev] Hello, some tech talk, etc.

[Taybin Rutkin]

On Jul 5, 2012, at 5:05 PM, Tim Mayberry <mojofunk at gmail.com> wrote:

> On Thu, Jul 5, 2012 at 10:54 PM, Sakari Bergen
> <sakari.bergen at beatwaves.net> wrote:
>> On Thu, Jul 5, 2012 at 3:38 PM, Tim Mayberry <mojofunk at gmail.com> wrote:
>>> 
>>> On Thu, Jul 5, 2012 at 1:37 PM, Paul Davis <paul at linuxaudiosystems.com>
>>> wrote:
>>>> 
>>>> 
>>>> On Wed, Jul 4, 2012 at 11:31 PM, Razvan Cojocaru <razvanco at gmx.net>
>>>> wrote:
>>>>> 
>>>>>>> 1) recursive mutexes are not acceptable. google around for
>>>>>>> decades-old
>>>>>>> criticisms and the story of how they came to be part of pthreads.
>>>>>> 
>>>>>> +1 !!
>>>>> 
>>>>> OK, so recursive mutexes are off-limits, but gotos are OK. :D
>>>> 
>>>> 
>>>> goto's as a mean of avoiding multiple exit points from a function
>>>> without
>>>> creating excessively complex nested conditionals are definitely OK.
>>>> gotos as
>>>> a means of restarting a loop under odd conditions is not ideal since it
>>>> can
>>>> normally be done better without them, but sometimes  it just feels
>>>> right.
>>>> 
>>> 
>>> To me it seems like many of the uses of goto in the ardour source
>>> result from a more "C style" of programming and with a little
>>> refactoring many could be removed if that was a goal.
>>> 
>>> I had a rough go at it this afternoon and removing about 20 out of the
>>> first 25 or so I encountered in libardour was fairly straight forward:
>>> https://github.com/mojofunk/ardour3-mingw/commits/goto

There is also the danger in changing known working code just to match the latest best practice.

Taybin