[ardour-dev] new user

Lincoln Spiteri lincoln.spiteri at gmail.com
Sat Jun 9 01:23:57 PDT 2007


Guess I should post a set of patches I recently submitted using Mantis here too.

The attched patch fixes the following:

Issue 1601 Wrong duplicate region behaviour
Issue 1682 Playhead does respond to clicks on the bar line
Issue 1724 Momentary unmuting of track when soloing

Lincoln

On 09/06/07, Dave Peticolas <dave at krondo.com> wrote:
> Taybin Rutkin wrote:
> > On Jun 7, 2007, at 11:58 PM, Dave Peticolas wrote:
> >
> >> Is that the appropriate way to submit patches?
> >
> > You can email patches to the list or append them to the bug tracker.
> > I'd do both, to make sure they don't get lost in the shuffle. :)
> >
> > Taybin
> >
>
> Gotcha. My patch is attached.
>
> dave
>
> Index: gtk2_ardour/editor_audio_import.cc
> ===================================================================
> --- gtk2_ardour/editor_audio_import.cc  (revision 1980)
> +++ gtk2_ardour/editor_audio_import.cc  (working copy)
> @@ -337,8 +337,8 @@
>                         vector<string> choices;
>
>                         if (multiple_files) {
> -                               choices.push_back (_("Cancel entire import"));
> -                               choices.push_back (_("Don't embed it"));
> +                               choices.push_back (_("Don't embed any"));
> +                               choices.push_back (_("Don't embed this one"));
>                                 choices.push_back (_("Embed all without questions"));
>
>                                 Gtkmm2ext::Choice rate_choice (
> @@ -350,7 +350,9 @@
>
>                                 switch (resx) {
>                                 case 0: /* stop a multi-file import */
> -                               case 1: /* don't import this one */
> +                                       ret = -2;
> +                                       goto out;
> +                               case 1: /* don't embed this one */
>                                         ret = -1;
>                                         goto out;
>                                 case 2: /* do it, and the rest without asking */
>
> _______________________________________________
> ardour-dev mailing list
> ardour-dev at lists.ardour.org
> http://lists.ardour.org/listinfo.cgi/ardour-dev-ardour.org
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ardour_patches.patch
Type: text/x-patch
Size: 2688 bytes
Desc: not available
URL: <http://lists.ardour.org/pipermail/ardour-dev-ardour.org/attachments/20070609/53573d7e/attachment-0002.bin>


More information about the Ardour-Dev mailing list