[ardour-dev] Fix for #1179 - splitting destroys adjacent crossfade

[Markus Schwarzenberg]

Hi Sampo,

On Mon, 20 Mar 2006 23:12:30 +0200 Sampo Savolainen <v2 at iki.fi> wrote:

> Patch attached.

Thanks, but sorry, your patch (currently applied to cvs) does not 
fix the bug. The "old" (before) split crossfade gets destroyed
(list::erase'd) in remove_region_internal --> remove_dependents(). 
Thus in finalize_split_region there will never be an old crossfade 
to be restored, i.e. nothing is done there.

Have a look at the screen shots (hope they don't get cut, and note 
transparency is partly cut (only in the pics) due to massive colormap 
compression)

* before-split.png ........ just before splitting the middle region 
* after-split-OK.png ...... desired behavior with the patch (attachment 
                            to #1179:) split-retain-xfades.diff.gz:
                            the old non-standard-crossfades have been 
                            transfered to the two new regions
* after-split-buggy.png ... only two standard crossfades (default
                            settings) have been created. This happens 
                            with as well as without the currently 
                            applied fix ( split_crossfade_fix.patch )
			    
For the current fix to work remove_region_internal and
remove_dependents would have to be signalled to avoid removing the
crossfades in questions somehow (optional argument?). Another solution
would be to defer remove_region_internal until add_region_internal 
is done (Still don't know possible side effects):

  	add_region_internal (left, ...) 
  	add_region_internal (right, ...) 

        transfer_crossfades (region, left, right, position)

        remove_region_internal( ... )

If you think that's a better approach  than my originally proposed 
patch I would start to work this out.


Markus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: after-split-OK.png
Type: image/png
Size: 4841 bytes
Desc: not available
URL: <http://lists.ardour.org/pipermail/ardour-dev-ardour.org/attachments/20060322/965940ef/attachment.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: after-split-buggy.png
Type: image/png
Size: 3655 bytes
Desc: not available
URL: <http://lists.ardour.org/pipermail/ardour-dev-ardour.org/attachments/20060322/965940ef/attachment-0001.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: before-split.png
Type: image/png
Size: 4839 bytes
Desc: not available
URL: <http://lists.ardour.org/pipermail/ardour-dev-ardour.org/attachments/20060322/965940ef/attachment-0002.png>