[ardour-dev] 0.99.1 causing plugin crash?

[Sampo Savolainen]

The "+ offset" part was added by me between 0.99 and 0.99.1. For some
reason, I didn't look at the surrounding code and didn't notice that.
Taking the buffer offset into account must have triggered nasty results
from that.

Thank you very much for finding this issue.

The CVS snapshot is rebuilt:
http://www.ardour.org/releases/ardour-cvs.tar.bz2

Please test & confirm that the issue is really gone.


  Sampo

On Sat, 2006-02-11 at 13:47 +0100, fons adriaensen wrote:
> On Sat, Feb 11, 2006 at 01:11:46AM +0100, fons adriaensen wrote:
> 
> > I mean that when the track is muted, one of the inputs is not
> > cleared to zero, and the output from cycle N is fed back as the
> > input in cycle N+1.
> 
> See libs/ardour/ladspa_plugin.cc, int LadspaPlugin::connect_and_run():
> 
>     connect_port (port_index, bufs[min((uint32_t) in_index,nbufs)] + offset);
> 
> If min() does what I think it does, this should be:
> 
>     connect_port (port_index, bufs[min((uint32_t) in_index,nbufs-1)] + offset);
> 
> Same for the output ports a few lines below.
> 
> This seems to solve the problem I reported.
> 
-- 
Sampo Savolainen <v2 at iki.fi>