[ardour-dev] patch for ardour2 generic midi control surface feedback

[John Anderson]

On Tue, 2006-12-19 at 09:18 -0500, Paul Davis wrote:
> On Tue, 2006-12-19 at 06:50 +0000, John Anderson wrote:
> 
> > It works when I set
> > 
> > bool MIDIControllable::_send_feedback = true;
> > 
> > in libs/surfaces/generic_midi/midicontrollable.cc
> > 
> > mainly because (AFAICS) MIDIControllable::write_feedback checks the
> > value of _send_feedback before it does anything. But nothing I can find
> > sets the value of _send_feedback to true.
> 
> fixed in svn. it appears i was in mid-thought on how to make that stuff
> work, and never really finished it off. there is now no class-wide
> "_send_feedback", only the per-instance "feedback" member, and it
> defaults to true. its state is saved and restored as well.

Yeah, it's working nicely now.

> > I also discovered that when loading up a new session, the first control
> > binding in the ControlProtocols/Protocol section of the session file
> > isn't restored. Mantis?
> 
> i'll look at it this morning.

Cool. I'm also seeing some interesting things with save and restore. The
session I've been testing with now has 2 <Protocol name="Generic
MIDI".../> sections, with duplicates of some of the entries in
<controls> - both inside one section and across the two sections. Also,
Options/Control Surfaces/Generic MIDI and Options/Control
Surfaces/Generic MIDI/Feedback are not ticked on session restore.

bye
John