[ardour-dev] patch for ardour2 generic midi control surface feedback

[John Anderson]

On Mon, 2006-12-18 at 21:42 -0500, Paul Davis wrote:
> On Sun, 2006-12-17 at 16:48 +0000, John Anderson wrote:
> > Feedback for the Generic MIDI control surface hasn't been working in
> > ardour2. This patch makes it work. Made against revision 1220. It
> > doesn't address the following:
> 
> i didn't apply this as-is, but tried to take what you had learnt and
> re-implemented it. please let me know if it works. i did not make
> feedback enabled by default, as your patch did.
> 
> its in my most recent commit (rev 1223)

It works when I set

bool MIDIControllable::_send_feedback = true;

in libs/surfaces/generic_midi/midicontrollable.cc

mainly because (AFAICS) MIDIControllable::write_feedback checks the
value of _send_feedback before it does anything. But nothing I can find
sets the value of _send_feedback to true.

I also discovered that when loading up a new session, the first control
binding in the ControlProtocols/Protocol section of the session file
isn't restored. Mantis?

bye
John